singhpk234 commented on code in PR #3064:
URL: https://github.com/apache/polaris/pull/3064#discussion_r2532950192
##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/resolver/PolarisResolutionManifest.java:
##########
@@ -68,6 +68,14 @@ public class PolarisResolutionManifest implements
PolarisResolutionManifestCatal
// Set when resolveAll is called
private ResolverStatus primaryResolverStatus = null;
+ private ResolverStatus requirePrimaryResolverStatus() {
Review Comment:
minor : require gives an impression that its just doing assertion, but its
additionally returning status how about this
```suggestion
private ResolverStatus safeGetPrimaryResolverStatus() {
```
##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/resolver/PolarisResolutionManifest.java:
##########
@@ -277,6 +285,7 @@ public PolarisResolvedPathWrapper
getResolvedRootContainerEntityAsPath() {
public PolarisResolvedPathWrapper getResolvedReferenceCatalogEntity(
boolean prependRootContainer) {
+ requirePrimaryResolverStatus();
Review Comment:
[doubt] is just checking status not null sufficient ? or should we bake the
assertion that that status != null and status = SUCCESS ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
