flyrain commented on PR #3064:
URL: https://github.com/apache/polaris/pull/3064#issuecomment-3543461329
> @flyrain : could you explain why "resolveAll() _must_ be called before
reading resolution results"? The PR description provides information about
enforcing it, but the rationale for doing that is not very clear... at least to
me 😅 Thx!
The result will be invalid, or null if it's not invoked. The concurrent code
actually already enforce that. You can find these in each place reading the
result, but NPE will be threw in case of `resovleAll()` not called. This PR is
mainly to make it fail explicitly instead of a NPE.
```
if (primaryResolverStatus.getStatus() != ResolverStatus.StatusEnum.SUCCESS) {
return null
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
