MonkeyCanCode commented on code in PR #3036: URL: https://github.com/apache/polaris/pull/3036#discussion_r2540546721
########## .github/workflows/python-client-release-pypi-artifact.yml: ########## @@ -0,0 +1,102 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +name: "Build Python Client Release Pypi Artifacts" + +on: + workflow_call: + inputs: + VERSION: + required: true + type: string + +jobs: + pypi-build-artifacts: + name: Build artifacts for SVN on ${{ matrix.os }} + runs-on: ${{ matrix.os }} + strategy: + matrix: + os: [ ubuntu-24.04, macos-14, macos-15] # current build script is not compatible with windows + + steps: + - uses: actions/checkout@v5 + with: + fetch-depth: 1 + + - name: Set up Python + uses: actions/setup-python@v6 + with: + python-version: | + 3.10 + 3.11 + 3.12 + 3.13 + - name: Set up JDK for openapi-generator-cli + uses: actions/setup-java@dded0888837ed1f317902acf8a20df0ad188d165 # v5 + with: + distribution: 'temurin' + java-version: '21' + + - name: Set version with RC + run: + + - name: Set version with RC + env: + VERSION: ${{ inputs.VERSION }} + run: make client-set-version VERSION="${{ env.VERSION }}" + + - name: Build source distribution + run: | + make client-build FORMAT=sdist + + - name: Build wheels + uses: pypa/[email protected] + with: + output-dir: wheelhouse + package-dir: "./client/python" + config-file: "{package}/pyproject.toml" + env: + # Ignore 32 bit architectures + CIBW_ARCHS: "auto64" + CIBW_PROJECT_REQUIRES_PYTHON: ">=3.9,<3.14" + CIBW_REPAIR_WHEEL_COMMAND_MACOS: "" # Disable wheel repair since there will be no binary in the wheel + CIBW_REPAIR_WHEEL_COMMAND_LINUX: "" + CIBW_ENVIRONMENT: POLARIS_CLI_SKIP_CLIENT_GENERATION="true" # java is not available in linux containers during wheel build, skip client generation + + - name: Add source distribution + if: startsWith(matrix.os, 'ubuntu-24.04') + run: ls -lah ./client/python/dist/* && cp ./client/python/dist/* wheelhouse/ + Review Comment: NIT: extra new line ########## .github/workflows/python-release-build.yml: ########## @@ -0,0 +1,123 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +name: "Python Client Build Release Candidate" + +on: + workflow_dispatch: + inputs: + version: + description: 'Version (e.g. 1.1.0)' + type: string + required: true + rc: + description: 'Release Candidate (RC) (e.g. 1)' + type: number + required: true + pull_request: + paths: + - '.github/workflows/python-release-build.yml' + - '.github/workflows/python-client-release-svn-artifact.yml' + - 'client/python/**' + +jobs: + validate-inputs: + runs-on: ubuntu-latest + outputs: + VERSION: ${{ steps.validate-inputs.outputs.VERSION }} + RC: ${{ steps.validate-inputs.outputs.RC }} + steps: + - name: Validate Version and RC + id: validate-inputs + run: | + # Use test values for pull_request trigger, actual inputs for workflow_dispatch + if [[ "${{ github.event_name }}" == "pull_request" ]]; then + echo "Workflow triggered by pull_request - using test values" + VERSION="1.2.0" Review Comment: NIT: Not sure if we should use `1.2.0` as the default version during test. Maybe we should do `0.0.0` instead to avoid confusion? ########## .github/workflows/python-client-release-pypi-artifact.yml: ########## @@ -0,0 +1,102 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +name: "Build Python Client Release Pypi Artifacts" Review Comment: NIT: `Pypi` to `PyPI` ########## .github/workflows/python-client-release-svn-artifact.yml: ########## @@ -0,0 +1,94 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +name: "Build Python Client Release SVN Artifacts" + +on: + workflow_call: + inputs: + VERSION: + required: true + type: string + +jobs: + svn-build-artifacts: + name: Build artifacts for SVN on ${{ matrix.os }} + runs-on: ${{ matrix.os }} + strategy: + matrix: + os: [ ubuntu-24.04, macos-14, macos-15] # current build script is not compatible with windows + + steps: + - uses: actions/checkout@v5 + with: + fetch-depth: 1 + + - name: Set up Python + uses: actions/setup-python@v6 + with: + python-version: | + 3.10 + 3.11 + 3.12 + 3.13 + - name: Set up JDK for openapi-generator-cli + uses: actions/setup-java@dded0888837ed1f317902acf8a20df0ad188d165 # v5 + with: + distribution: 'temurin' + java-version: '21' + + - name: Build source distribution + run: | + make client-build FORMAT=sdist + + - name: Build wheels + uses: pypa/[email protected] + with: + output-dir: wheelhouse + package-dir: "./client/python" + config-file: "{package}/pyproject.toml" + env: + # Ignore 32 bit architectures + CIBW_ARCHS: "auto64" + CIBW_PROJECT_REQUIRES_PYTHON: ">=3.9,<3.14" Review Comment: Same as above, python version bump to `3.10` ########## .github/workflows/python-client-release-pypi-artifact.yml: ########## @@ -0,0 +1,102 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +name: "Build Python Client Release Pypi Artifacts" + +on: + workflow_call: + inputs: + VERSION: + required: true + type: string + +jobs: + pypi-build-artifacts: + name: Build artifacts for SVN on ${{ matrix.os }} + runs-on: ${{ matrix.os }} + strategy: + matrix: + os: [ ubuntu-24.04, macos-14, macos-15] # current build script is not compatible with windows + + steps: + - uses: actions/checkout@v5 + with: + fetch-depth: 1 + + - name: Set up Python + uses: actions/setup-python@v6 + with: + python-version: | + 3.10 + 3.11 + 3.12 + 3.13 + - name: Set up JDK for openapi-generator-cli + uses: actions/setup-java@dded0888837ed1f317902acf8a20df0ad188d165 # v5 + with: + distribution: 'temurin' + java-version: '21' + + - name: Set version with RC Review Comment: dup step. ########## .github/workflows/python-client-release-svn-artifact.yml: ########## @@ -0,0 +1,94 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +name: "Build Python Client Release SVN Artifacts" + +on: + workflow_call: + inputs: + VERSION: + required: true + type: string + +jobs: + svn-build-artifacts: + name: Build artifacts for SVN on ${{ matrix.os }} + runs-on: ${{ matrix.os }} + strategy: + matrix: + os: [ ubuntu-24.04, macos-14, macos-15] # current build script is not compatible with windows + + steps: + - uses: actions/checkout@v5 + with: + fetch-depth: 1 + + - name: Set up Python + uses: actions/setup-python@v6 + with: + python-version: | + 3.10 + 3.11 + 3.12 + 3.13 + - name: Set up JDK for openapi-generator-cli + uses: actions/setup-java@dded0888837ed1f317902acf8a20df0ad188d165 # v5 + with: + distribution: 'temurin' + java-version: '21' + + - name: Build source distribution + run: | + make client-build FORMAT=sdist + + - name: Build wheels + uses: pypa/[email protected] + with: + output-dir: wheelhouse + package-dir: "./client/python" + config-file: "{package}/pyproject.toml" + env: + # Ignore 32 bit architectures + CIBW_ARCHS: "auto64" + CIBW_PROJECT_REQUIRES_PYTHON: ">=3.9,<3.14" + CIBW_REPAIR_WHEEL_COMMAND_MACOS: "" # Disable wheel repair since there will be no binary in the wheel + CIBW_REPAIR_WHEEL_COMMAND_LINUX: "" + CIBW_ENVIRONMENT: POLARIS_CLI_SKIP_CLIENT_GENERATION="true" # java is not available in linux containers during wheel build, skip client generation + + - name: Add source distribution + if: startsWith(matrix.os, 'ubuntu-24.04') + run: ls -lah ./client/python/dist/* && cp ./client/python/dist/* wheelhouse/ + Review Comment: Same as above, extra new line. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
