binarycat0 commented on code in PR #3036: URL: https://github.com/apache/polaris/pull/3036#discussion_r2541884705
########## .github/workflows/python-release-build.yml: ########## @@ -0,0 +1,123 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +name: "Python Client Build Release Candidate" + +on: + workflow_dispatch: + inputs: + version: + description: 'Version (e.g. 1.1.0)' + type: string + required: true + rc: + description: 'Release Candidate (RC) (e.g. 1)' + type: number + required: true + pull_request: + paths: + - '.github/workflows/python-release-build.yml' + - '.github/workflows/python-client-release-svn-artifact.yml' + - 'client/python/**' + +jobs: + validate-inputs: + runs-on: ubuntu-latest + outputs: + VERSION: ${{ steps.validate-inputs.outputs.VERSION }} + RC: ${{ steps.validate-inputs.outputs.RC }} + steps: + - name: Validate Version and RC + id: validate-inputs + run: | + # Use test values for pull_request trigger, actual inputs for workflow_dispatch + if [[ "${{ github.event_name }}" == "pull_request" ]]; then + echo "Workflow triggered by pull_request - using test values" + VERSION="1.2.0" Review Comment: Hello 👋 Just want to highlight that in [this dev@ thread](https://lists.apache.org/thread/0tzko7doy6ykjw51wk6nto3jmwlkh71v) was discussed legal aspects and versioning. I think it's better to sync with JB and other engineers who has expertise. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
