dimas-b commented on code in PR #3067: URL: https://github.com/apache/polaris/pull/3067#discussion_r2542677237
########## CONTRIBUTING.md: ########## @@ -142,5 +142,5 @@ To ensure smooth collaboration and to maintain a high-quality codebase, please a * `git log` can help you find the original/relevant authors of the code you are modifying. If you need, feel free to tag the author in your Pull Request comment if you need assistance or review. * Do not re-create a pull-request for the same change. Use one Pull Request related to the same change(s). The purpose here is to keep the history and all comments in the Pull Request. * Consider open questions and concerns in all comments of your Pull Request, provide replies and resolve addressed comments, if those don't serve reference purposes. If a comment doesn't contain `nit`, `minor`, or `not a blocker` mention, please provide feedback to the comment before merging. -* Give time for review. For instance two working days is a good base to get first reviews and comments. +* Give time for review. For instance two working days is a good base to get first reviews and comments for changes that are not likely to affect downstream projects. For changes that touch core interfaces and behaviours three working days would be advisable. Review Comment: SPI/API are not well-defined in Polaris now, IMHO. The discussion linked above is a good starting point, IMHO, but I do not think we completely ironed it out yet :sweat_smile: Let's continue the `dev` discussion by email and upgrade guidelines when we have a solid definition of SPI/API. For now, I believe it has to remain a big vague and applied with common sense. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
