adam-christian-software commented on code in PR #3067: URL: https://github.com/apache/polaris/pull/3067#discussion_r2550203359
########## CONTRIBUTING.md: ########## @@ -142,5 +142,20 @@ To ensure smooth collaboration and to maintain a high-quality codebase, please a * `git log` can help you find the original/relevant authors of the code you are modifying. If you need, feel free to tag the author in your Pull Request comment if you need assistance or review. * Do not re-create a pull-request for the same change. Use one Pull Request related to the same change(s). The purpose here is to keep the history and all comments in the Pull Request. * Consider open questions and concerns in all comments of your Pull Request, provide replies and resolve addressed comments, if those don't serve reference purposes. If a comment doesn't contain `nit`, `minor`, or `not a blocker` mention, please provide feedback to the comment before merging. -* Give time for review. For instance two working days is a good base to get first reviews and comments. +* All changes to REST API specs should be accompanied by an email to the `dev` list for visibility. * If you have the feeling that the discussions in a Pull Request are not going to a consensus, feel free to bring the discussion on the dev mailing list. + +## PR Review Guidelines + +* Smaller changes that are not likely to affect end users or downstream projects can be merged on + immediately on approval. If concerns are flagged later, they are to be addressed in follow-up PRs. +* Waiting at least two working days is recommented (even if the PR has approvals from some reviewers) for: Review Comment: Nit (spelling): recommented -> recommended -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
