flyrain commented on code in PR #3113:
URL: https://github.com/apache/polaris/pull/3113#discussion_r2589995177
##########
polaris-core/src/main/java/org/apache/polaris/core/config/FeatureConfiguration.java:
##########
@@ -438,4 +438,47 @@ public static void enforceFeatureEnabledOrThrow(
"If set to true (default), allow credential vending for external
catalogs. Note this requires ALLOW_EXTERNAL_CATALOG_CREDENTIAL_VENDING to be
true first.")
.defaultValue(true)
.buildFeatureConfiguration();
+
+ public static final FeatureConfiguration<Integer> CLOUD_API_TIMEOUT_MILLIS =
Review Comment:
@fivetran-rahulprakash , thanks for the change! One small concern, different
storage backends may eventually need different timeout/retry configs. We can
always introduce a broader-scope config like `STORAGE_API_TIMEOUT_MILLIS` later
if we find something truly common across all storage types, but evolving in the
opposite direction is harder. Once a wide-scope config is adopted and used in
different places, shrinking it down to a more specific scope becomes much more
painful. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
