RahulPrakash96 commented on code in PR #3113:
URL: https://github.com/apache/polaris/pull/3113#discussion_r2587687629
##########
polaris-core/src/main/java/org/apache/polaris/core/config/FeatureConfiguration.java:
##########
@@ -438,4 +438,47 @@ public static void enforceFeatureEnabledOrThrow(
"If set to true (default), allow credential vending for external
catalogs. Note this requires ALLOW_EXTERNAL_CATALOG_CREDENTIAL_VENDING to be
true first.")
.defaultValue(true)
.buildFeatureConfiguration();
+
+ public static final FeatureConfiguration<Integer> CLOUD_API_TIMEOUT_MILLIS =
Review Comment:
Good call! I've changed it to STORAGE_API_* to be more specific.
While only Azure uses these configs right now, the timeout/retry pattern
applies to other cloud storage providers (AWS S3, GCP) too - their SDKs have
similar async patterns that would benefit from this. So keeping the naming
generic makes it easier to reuse when we add resilience to those integrations
later.
Updated the descriptions to clarify it's currently Azure only but designed
for future reuse. Let me know if you'd prefer something different!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
