HonahX commented on code in PR #3200:
URL: https://github.com/apache/polaris/pull/3200#discussion_r2590258640
##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/dao/entity/EntityResult.java:
##########
@@ -87,15 +85,6 @@ public PolarisEntitySubType getAlreadyExistsEntitySubType() {
}
}
- @JsonCreator
- private EntityResult(
Review Comment:
Hi @dimas-b Thanks for the effort of improving clarity of the core module.
These private constructors are there for these classes to be JSON Serdes, which
will be useful for downstream integration where the MetaStoreManager is talking
to a remote persistence server via Rest API.
Could we keep these constructor to preserve the JSON Serdes for these
classes. It would also be ok if we replace these with static JsonCreator if
that help make things clearer.
I am also thinking of adding roundtrip test for these classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
