dimas-b commented on code in PR #3200:
URL: https://github.com/apache/polaris/pull/3200#discussion_r2591039434
##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/dao/entity/EntityResult.java:
##########
@@ -87,15 +85,6 @@ public PolarisEntitySubType getAlreadyExistsEntitySubType() {
}
}
- @JsonCreator
- private EntityResult(
Review Comment:
@HonahX : How can the serde removed in this PR be a convention in Polaris,
when it is not used in Polaris build or runtime?
My exact point is that it is a convention in a downstream project, but not
in Polaris itself.
As I mentioned above, I do not insist on merging this PR. However, it is an
illustration of downstream dependencies that exists only in downstream code.
Successful CI on this PR shows that Polaris itself does not rely on this code.
Ideally, IMHO, downstream projects that rely on serializing these objects
should probably implement and maintain serde (via JSON or overwise) by
themselves.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
