HonahX commented on code in PR #3215:
URL: https://github.com/apache/polaris/pull/3215#discussion_r2593695704
##########
site/content/in-dev/unreleased/command-line-interface.md:
##########
@@ -156,7 +158,7 @@ options:
--consent-url (Only for Azure) A consent URL granting permissions for
the Azure Storage location
--service-account (Only for GCS) The service account to use when
connecting to GCS
--property A key/value pair such as: tag=value. Multiple can be
provided by specifying this option more than once
- --catalog-connection-type The type of external catalog in
[iceberg-rest, hadoop, hive].
+ --catalog-connection-type The type of external catalog in [ICEBERG,
HADOOP, HIVE].
Review Comment:
Yes, it should be the lower cased version, since they are the actual value
of those enum type:
https://github.com/apache/polaris/blob/be3c88b6d057009a05301a25ef99b775604955ea/client/python/apache_polaris/cli/constants.py#L51-L58
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
