sfc-gh-jojiang commented on code in PR #3215:
URL: https://github.com/apache/polaris/pull/3215#discussion_r2595900924
##########
site/content/in-dev/unreleased/command-line-interface.md:
##########
@@ -156,7 +158,7 @@ options:
--consent-url (Only for Azure) A consent URL granting permissions for
the Azure Storage location
--service-account (Only for GCS) The service account to use when
connecting to GCS
--property A key/value pair such as: tag=value. Multiple can be
provided by specifying this option more than once
- --catalog-connection-type The type of external catalog in
[iceberg-rest, hadoop, hive].
+ --catalog-connection-type The type of external catalog in [ICEBERG,
HADOOP, HIVE].
Review Comment:
Thanks for diving deep into this！
Upper case SGTM. As for the iceberg-rest to iceberg change that would be a
breaking change for current users. It's worth to mention in the changelog if we
modify it.
IMHO, ICEBERG-REST should be fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
