dimas-b commented on code in PR #3246:
URL: https://github.com/apache/polaris/pull/3246#discussion_r2604870601
##########
polaris-core/src/main/java/org/apache/polaris/core/storage/gcp/GcpCredentialsStorageIntegration.java:
##########
@@ -123,6 +134,46 @@ public StorageAccessConfig getSubscopedCreds(
return accessConfig.build();
}
+ /**
+ * Returns the credential to be used as the source for downscoping. If a
specific service account
+ * is configured, it impersonates that account first.
+ */
+ private GoogleCredentials getBaseCredentials() {
+ if (config().getGcpServiceAccount() != null) {
Review Comment:
Interesting that this config value was defined before, but not used 🤔
Does anyone have insight into why it was this way?
Technically, now that `GcpServiceAccount` config values start affecting
Polaris behaviour, this could be a breaking change in existing deployments that
may have (possibly accidental and/or incorrect) values in that config property.
I do believe that such a situation is unlikely, so it should be fine to
proceed with this PR. However, it probably deserves mentioning as a `Change` in
CHANGELOG.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
