flyrain commented on code in PR #3246:
URL: https://github.com/apache/polaris/pull/3246#discussion_r2608311624
##########
polaris-core/src/main/java/org/apache/polaris/core/storage/gcp/GcpCredentialsStorageIntegration.java:
##########
@@ -123,6 +134,46 @@ public StorageAccessConfig getSubscopedCreds(
return accessConfig.build();
}
+ /**
+ * Returns the credential to be used as the source for downscoping. If a
specific service account
+ * is configured, it impersonates that account first.
+ */
+ private GoogleCredentials getBaseCredentials() {
+ if (config().getGcpServiceAccount() != null) {
Review Comment:
Looks like this is in the CLI doc for a while,
https://polaris.apache.org/in-dev/unreleased/command-line-interface/#catalogs
```
--service-account (Only for GCS) The service account to use when
connecting to GCS
```
Agreed with @dimas-b, not particularly a big concern, but +1 on adding this
to the CHANGELOG.md.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
