HonahX commented on code in PR #3036: URL: https://github.com/apache/polaris/pull/3036#discussion_r2611417475
########## .github/workflows/python-client-build-artifacts.yml: ########## @@ -0,0 +1,122 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +name: "Python Client Build Artifacts" + +on: + workflow_dispatch: + inputs: + version: + description: 'Version to set (optional, e.g. 1.1.0 or 1.1.0rc1 or dev-20251202-abc1234)' + type: string + required: false + workflow_call: + inputs: + version: + description: 'Version to set (optional)' + type: string + required: false + pull_request: + paths: + - '.github/workflows/python-client-build-artifacts.yml' + - 'client/python/**' Review Comment: The `version` here is optional and used to set the package version here ``` - name: Set version (if provided) if: inputs.version != '' env: VERSION: ${{ inputs.version }} run: make client-set-version VERSION="${{ env.VERSION }}" ``` In the nightly build, we will need to determine a convention of the package version for nightly build, such as including commit hash/date to the package version, so we could have a better reference in test.pypi.org. But IMHO the details of the version we want to set to the package could be determined in the actual nightly build publication step. This workflow should focus on building all the wheels required, by default leave the package version unchanged and make it an option for any upstream caller to set the version as needed. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
