HonahX commented on PR #3036:
URL: https://github.com/apache/polaris/pull/3036#issuecomment-3726590099

   Hi @snazy I've removed the version input option and make it the snapshot 
version we want to tag our nightly build, e.g. `0.9.0.dev20231215`
   
   The workflow file is targeted to be used in 2 places: 
   - PR that involves client change to make sure all wheels are successfully 
built
   - Integration to the nightly.yaml.
   
   For the nightly build, the example usage is like
   ```yaml
   ...
   
   python-client-snapshot-build:
       if: github.repository == 'apache/polaris'
       uses: ./.github/workflows/python-client-build-artifacts.yml
   
     python-client-snapshot-publish:
       runs-on: ubuntu-latest
       needs: python-client-snapshot-build
       if: github.repository == 'apache/polaris'
       steps:
         - name: Download artifacts
           uses: actions/download-artifact@v4
           with:
             name: ${{ needs.python-client-snapshot-build.outputs.artifact-name 
}}
             path: dist/
   
         - name: List artifacts
           run: ls -la dist/
   
        - name: Publish to TestPyPI
          id: publish-testpypi
          continue-on-error: true
          uses: pypa/gh-action-pypi-publish@release/v1
          with:
            repository-url: https://test.pypi.org/legacy/
            skip-existing: true
            verbose: true
   ```
   In this way we do not need to put the multi-OS wheel built logic in the 
nightly publishing workflow. The artifacts downloaded in 
`python-client-snapshot-publish` will look like
   ```
   Contents of dist/:
   total 6676
   drwxr-xr-x 2 runner runner   4096 Jan  8 04:46 .
   drwxr-xr-x 3 runner runner   4096 Jan  8 04:46 ..
   -rw-r--r-- 1 runner runner 546036 Jan  8 04:46 
apache_polaris-1.4.0.dev20260108043602-cp310-cp310-macosx_14_0_arm64.whl
   -rw-r--r-- 1 runner runner 546038 Jan  8 04:46 
apache_polaris-1.4.0.dev20260108043602-cp310-cp310-macosx_15_0_arm64.whl
   -rw-r--r-- 1 runner runner 546041 Jan  8 04:46 
apache_polaris-1.4.0.dev20260108043602-cp310-cp310-manylinux_2_39_x86_64.whl
   -rw-r--r-- 1 runner runner 546036 Jan  8 04:46 
apache_polaris-1.4.0.dev20260108043602-cp311-cp311-macosx_14_0_arm64.whl
   -rw-r--r-- 1 runner runner 546037 Jan  8 04:46 
apache_polaris-1.4.0.dev20260108043602-cp311-cp311-macosx_15_0_arm64.whl
   -rw-r--r-- 1 runner runner 546040 Jan  8 04:46 
apache_polaris-1.4.0.dev20260108043602-cp311-cp311-manylinux_2_39_x86_64.whl
   -rw-r--r-- 1 runner runner 546037 Jan  8 04:46 
apache_polaris-1.4.0.dev20260108043602-cp312-cp312-macosx_14_0_arm64.whl
   -rw-r--r-- 1 runner runner 546038 Jan  8 04:46 
apache_polaris-1.4.0.dev20260108043602-cp312-cp312-macosx_15_0_arm64.whl
   -rw-r--r-- 1 runner runner 546039 Jan  8 04:46 
apache_polaris-1.4.0.dev20260108043602-cp312-cp312-manylinux_2_39_x86_64.whl
   -rw-r--r-- 1 runner runner 546039 Jan  8 04:46 
apache_polaris-1.4.0.dev20260108043602-cp313-cp313-macosx_14_0_arm64.whl
   -rw-r--r-- 1 runner runner 546038 Jan  8 04:46 
apache_polaris-1.4.0.dev20260108043602-cp313-cp313-macosx_15_0_arm64.whl
   -rw-r--r-- 1 runner runner 546040 Jan  8 04:46 
apache_polaris-1.4.0.dev20260108043602-cp313-cp313-manylinux_2_39_x86_64.whl
   -rw-r--r-- 1 runner runner 237998 Jan  8 04:46 
apache_polaris-1.4.0.dev20260108043602.tar.gz
   ``` 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to