flyrain commented on code in PR #3215:
URL: https://github.com/apache/polaris/pull/3215#discussion_r2617614902
##########
site/content/in-dev/unreleased/command-line-interface.md:
##########
@@ -156,7 +158,7 @@ options:
--consent-url (Only for Azure) A consent URL granting permissions for
the Azure Storage location
--service-account (Only for GCS) The service account to use when
connecting to GCS
--property A key/value pair such as: tag=value. Multiple can be
provided by specifying this option more than once
- --catalog-connection-type The type of external catalog in
[iceberg-rest, hadoop, hive].
+ --catalog-connection-type The type of external catalog in [ICEBERG,
HADOOP, HIVE].
Review Comment:
I tested this against the `main` branch. Passing `--catalog-connection-type
ICEBERG` currently fails with the following error:
```
yufei@Yufeis-MacBook-Pro-2 polaris % ./polaris --profile dev catalogs create
--type external --catalog-connection-type ICEBERG --default-base-location
file://temp/c1 --storage-type file --catalog-authentication-type BEARER
--catalog-bearer-token my-token-xxx c1
usage: ...
polaris catalogs create: error: argument --catalog-connection-type: invalid
choice: 'iceberg' (choose from 'hadoop', 'iceberg-rest', 'hive')
```
Given that we’ve already been using `ICEBERG_REST` on the server side, I
think it makes sense to keep it as-is to avoid introducing a breaking change.
Sorry for the confusion earlier, I didn’t mean to suggest changing it to
`ICEBERG-REST`.
For the CLI, one option could be to standardize on uppercase enum-style
values (e.g. `ICEBERG_REST`, `HADOOP`, `HIVE`) for consistency with other
arguments.
What do you think? @MonkeyCanCode @HonahX
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
