adutra commented on code in PR #3281:
URL: https://github.com/apache/polaris/pull/3281#discussion_r2623272464
##########
persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/QuarkusRelationalJdbcConfiguration.java:
##########
@@ -16,10 +16,9 @@
* specific language governing permissions and limitations
* under the License.
*/
-package org.apache.polaris.quarkus.common.config.jdbc;
+package org.apache.polaris.persistence.relational.jdbc;
import io.smallrye.config.ConfigMapping;
-import
org.apache.polaris.persistence.relational.jdbc.RelationalJdbcConfiguration;
@ConfigMapping(prefix = "polaris.persistence.relational.jdbc")
public interface QuarkusRelationalJdbcConfiguration extends
RelationalJdbcConfiguration {}
Review Comment:
This subinterface is now useless. I suggest removing it and placing the
`@ConfigMapping` annotation directly on `RelationalJdbcConfiguration`.
##########
persistence/relational-jdbc/build.gradle.kts:
##########
@@ -33,8 +33,11 @@ dependencies {
compileOnly(libs.jakarta.enterprise.cdi.api)
compileOnly(libs.jakarta.inject.api)
+ compileOnly(libs.smallrye.config.core) // @ConfigMapping for Quarkus
integration
implementation(libs.smallrye.common.annotation) // @Identifier
implementation(libs.postgresql)
+ implementation(platform(libs.quarkus.amazon.services.bom))
Review Comment:
This new dependency is intriguing. This module doesn't need the RDS
extension for compilation, not even for tests. If the intent is to create a
Polaris server distribution that supports Amazon RDS, I wonder if a better
approach wouldn't be to include the RDS Quarkus extension directly in
`polaris-server`?
Conversely, if we decide to keep this dependency here: it is bringing
`quarkus-core` transitively. This means that this module becomes de facto a
Quarkus module. In this case we should declare the dependency
`implementation(platform(libs.quarkus.bom))` and add the Quarkus plugin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
