flyrain commented on code in PR #3281:
URL: https://github.com/apache/polaris/pull/3281#discussion_r2629053327
##########
persistence/relational-jdbc/build.gradle.kts:
##########
@@ -33,8 +33,11 @@ dependencies {
compileOnly(libs.jakarta.enterprise.cdi.api)
compileOnly(libs.jakarta.inject.api)
+ compileOnly(libs.smallrye.config.core) // @ConfigMapping for Quarkus
integration
implementation(libs.smallrye.common.annotation) // @Identifier
implementation(libs.postgresql)
+ implementation(platform(libs.quarkus.amazon.services.bom))
Review Comment:
Thanks for the feedback, @dimas-b! I can definitely do that. One question /
concern though:
> I do believe that runtime library dependencies should be concentrated in
the runtime/server module.
Can you share a bit more of the rationale behind that? My worry is that if
we always push impl-specific deps into runtime/server, the server distribution
may end up pulling in everything (JDBC, Spanner, MongoDB, etc.) even when users
only need one backend.
Is that the intended direction (a “batteries-included” server), or should we
aim for something more modular, e.g., keeping the server lean and enabling
backends via optional/default modules/profiles so users can trim dependencies
based on their needs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
