dimas-b commented on code in PR #3281:
URL: https://github.com/apache/polaris/pull/3281#discussion_r2631306672
##########
persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/JdbcMetaStoreManagerFactory.java:
##########
@@ -196,15 +196,20 @@ public Map<String, BaseResult>
purgeRealms(Iterable<String> realms) {
for (String realm : realms) {
RealmContext realmContext = () -> realm;
- PolarisMetaStoreManager metaStoreManager =
getOrCreateMetaStoreManager(realmContext);
- BasePersistence session = getOrCreateSession(realmContext);
-
- PolarisCallContext callContext = new PolarisCallContext(realmContext,
session);
- BaseResult result = metaStoreManager.purge(callContext);
- results.put(realm, result);
-
- sessionSupplierMap.remove(realm);
- metaStoreManagerMap.remove(realm);
+ try {
+ PolarisMetaStoreManager metaStoreManager =
getOrCreateMetaStoreManager(realmContext);
+ BasePersistence session = getOrCreateSession(realmContext);
+
+ PolarisCallContext callContext = new PolarisCallContext(realmContext,
session);
+ BaseResult result = metaStoreManager.purge(callContext);
+ results.put(realm, result);
+
+ sessionSupplierMap.remove(realm);
+ metaStoreManagerMap.remove(realm);
+ } catch (IllegalStateException e) {
+ // Realm is not bootstrapped, return a failed result
+ results.put(realm, new
BaseResult(BaseResult.ReturnStatus.ENTITY_NOT_FOUND, e.getMessage()));
Review Comment:
I'm fine with catching `IllegalStateException` in general, but why should
the status be `ENTITY_NOT_FOUND` when we do not really know the root reason
:thinking: ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
