flyrain commented on code in PR #3281:
URL: https://github.com/apache/polaris/pull/3281#discussion_r2629164234
##########
persistence/relational-jdbc/build.gradle.kts:
##########
@@ -33,8 +33,11 @@ dependencies {
compileOnly(libs.jakarta.enterprise.cdi.api)
compileOnly(libs.jakarta.inject.api)
+ compileOnly(libs.smallrye.config.core) // @ConfigMapping for Quarkus
integration
implementation(libs.smallrye.common.annotation) // @Identifier
implementation(libs.postgresql)
+ implementation(platform(libs.quarkus.amazon.services.bom))
Review Comment:
Thanks for the explanation.
The default dependencies, esp. drivers are not only used by
`runtime/server`, but also the `admin` module. Instead of adding them to both,
how about putting them in the `runtime/default` module, and let both `admin`
and `server` depend on it? I think the downstream projects are not supposed to
reuse the `runtime/default` module. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
