obelix74 commented on code in PR #3327:
URL: https://github.com/apache/polaris/pull/3327#discussion_r2651520713
##########
polaris-core/src/main/java/org/apache/polaris/core/storage/cache/StorageCredentialCache.java:
##########
@@ -130,10 +146,9 @@ public StorageAccessConfig getOrGenerateSubScopeCreds(
allowedReadLocations,
allowedWriteLocations,
refreshCredentialsEndpoint,
- includePrincipalNameInSubscopedCredential
- ? Optional.of(polarisPrincipal)
- : Optional.empty());
- LOGGER.atDebug().addKeyValue("key", key).log("subscopedCredsCache");
+ includePrincipalInCacheKey ? Optional.of(polarisPrincipal) :
Optional.empty(),
+ includeSessionTags ? Optional.of(credentialVendingContext) :
Optional.empty());
+ LOGGER.atDebug().addKeyValue("key",
key.toSanitizedLogString()).log("subscopedCredsCache");
Review Comment:
Done. Removed the debug log statement since the sanitized key doesn't
provide useful debugging information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
