obelix74 commented on code in PR #3327:
URL: https://github.com/apache/polaris/pull/3327#discussion_r2651521198
##########
polaris-core/src/main/java/org/apache/polaris/core/storage/cache/StorageCredentialCache.java:
##########
@@ -144,7 +159,8 @@ public StorageAccessConfig getOrGenerateSubScopeCreds(
allowedReadLocations,
allowedWriteLocations,
polarisPrincipal,
- refreshCredentialsEndpoint);
+ refreshCredentialsEndpoint,
+ credentialVendingContext);
Review Comment:
Good catch! Fixed - the loader now uses
`k.credentialVendingContext().orElse(CredentialVendingContext.empty())` to
ensure we use the context from the cache key rather than the local variable.
This ensures consistent behavior when session tags are disabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
