flyrain commented on code in PR #3340:
URL: https://github.com/apache/polaris/pull/3340#discussion_r2666706183
##########
runtime/server/src/main/java/org/apache/polaris/admintool/PolarisAdminTool.java:
##########
@@ -36,8 +33,8 @@ public class PolarisAdminTool extends BaseMetaStoreCommand {
@Override
public Integer call() {
- PrintWriter out = spec.commandLine().getOut();
- spec.commandLine().usage(out);
+ // When invoked without a subcommand, show usage
Review Comment:
Both work per my test. I have removed the comment to avoid confusion.
```
yufei@Yufeis-MacBook-Pro-2 polaris % java -jar
runtime/server/build/quarkus-app/quarkus-run.jar -h
Usage: polaris-admin-tool.jar [-hV] [COMMAND]
Polaris administration & maintenance tool
-h, --help Show this help message and exit.
-V, --version Print version information and exit.
Commands:
help Display help information about the specified command.
bootstrap Bootstraps realms and root principal credentials.
purge Purge realms and all associated entities.
yufei@Yufeis-MacBook-Pro-2 polaris % java -jar
runtime/server/build/quarkus-app/quarkus-run.jar purge -h
Usage: polaris-admin-tool.jar purge [-hV] -r=<realm> [-r=<realm>]...
Purge realms and all associated entities.
-h, --help Show this help message and exit.
-r, --realm=<realm> The name of a realm to purge.
-V, --version Print version information and exit.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]