flyrain commented on code in PR #3340:
URL: https://github.com/apache/polaris/pull/3340#discussion_r2666503070
##########
persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/RelationalJdbcProductionReadinessChecks.java:
##########
@@ -39,6 +40,11 @@ public ProductionReadinessCheck checkRelationalJdbc(
return ProductionReadinessCheck.OK;
}
+ // Skip check if datasource is not available (e.g., in CLI mode before
configuration)
+ if (dataSource.isUnsatisfied() || dataSource.isAmbiguous()) {
+ return ProductionReadinessCheck.OK;
Review Comment:
Removed, I think these changes are not needed. Thanks for flagging it!
##########
persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/RelationalJdbcProductionReadinessChecks.java:
##########
@@ -48,6 +54,9 @@ public ProductionReadinessCheck checkRelationalJdbc(
"The current persistence (jdbc:h2) is intended for tests
only.",
"quarkus.datasource.jdbc.url"));
}
+ } catch (InactiveBeanException e) {
+ // Datasource is inactive (e.g., in CLI mode before configuration)
+ return ProductionReadinessCheck.OK;
Review Comment:
Same here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
