dimas-b commented on code in PR #3340: URL: https://github.com/apache/polaris/pull/3340#discussion_r2676849061
########## runtime/server/src/main/java/org/apache/polaris/admintool/BootstrapCommand.java: ########## Review Comment: Sorry for the last minute comment here, but I wonder if it might make sense to keep the `runtime/admin` module as a home for Admin code, but not build a Quarkus app from it. The `runtime/server` module will then import `runtime/admin` and we end up with one Quarkus app both for the Server and Admin Tool... WDYT? My rationale for keeping the `runtime/admin` module is just better code isolation at compile time. The `runtime/server` module is mostly an assembly descriptor, ATM it does not have any feature code. It might be preferable to keep it this way to allow simpler reused on feature code from their dedicated modules. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
