snazy commented on code in PR #3340:
URL: https://github.com/apache/polaris/pull/3340#discussion_r2681637072
##########
runtime/service/build.gradle.kts:
##########
@@ -33,8 +33,8 @@ dependencies {
runtimeOnly(project(":polaris-relational-jdbc"))
- implementation(project(":polaris-runtime-defaults"))
implementation(project(":polaris-runtime-common"))
+ implementation(project(":polaris-runtime-defaults"))
Review Comment:
Noop change in this big PR.
##########
LICENSE:
##########
@@ -328,7 +328,6 @@ This product includes code from Project Nessie.
*
tools/minio-testcontainer/src/main/java/org/apache/polaris/test/minio/MinioAccess.java
*
tools/minio-testcontainer/src/main/java/org/apache/polaris/test/minio/MinioContainer.java
*
tools/minio-testcontainer/src/main/java/org/apache/polaris/test/minio/MinioExtension.java
-*
runtime/admin/src/main/java/org/apache/polaris/admintool/PolarisAdminTool.java
Review Comment:
This file has been moved, not removed.
##########
runtime/defaults/src/main/resources/application.properties:
##########
@@ -292,4 +292,3 @@ quarkus.index-dependency.protobuf.artifact-id=protobuf-java
# force the locale, just in case the system's using another default locale
quarkus.default-locale=en_US
-
Review Comment:
Unrelated change to this already big PR.
##########
runtime/admin/distribution/LICENSE:
##########
Review Comment:
The LICENSE file contains entries that are not migrated.
##########
bom/build.gradle.kts:
##########
@@ -89,8 +89,6 @@ dependencies {
api(project(":polaris-extensions-auth-opa"))
- api(project(":polaris-admin"))
- api(project(":polaris-runtime-common"))
Review Comment:
This should not be removed from the bom
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
