dennishuo commented on PR #3396: URL: https://github.com/apache/polaris/pull/3396#issuecomment-3758321242
> > If you think that something in current `application.properties` is a blocker for merging, please specifically indicate what it is to allow for clarity in addressing these concerns. > > Hi @dimas-b, the Polaris "Code Contribution Guidelines" clarifies what's a blocker comment or not, https://polaris.apache.org/community/contributing-guidelines/. "Consider open questions and concerns in all comments of your Pull Request, provide replies and resolve addressed comments, if those don’t serve reference purposes. If a comment doesn’t contain nit, minor, or not a blocker mention, please provide feedback to the comment before merging." > > PR authors should honor this, do they? @dimas-b were you just asking for clarification on the preferred fix to the file as opposed to the nature of comments being blockers? Looks like the remaining open comment was about `quarkus.mongodb.database=polaris` needing clarification. @flyrain I also commented on that config key as something that raised eyebrows for me - would my suggestion of adding an explanatory comment and possibly also commenting it out by default also address your concern? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
