HonahX commented on code in PR #3396:
URL: https://github.com/apache/polaris/pull/3396#discussion_r2719386996
##########
runtime/service/build.gradle.kts:
##########
@@ -39,6 +39,12 @@ dependencies {
compileOnly(project(":polaris-immutables"))
annotationProcessor(project(":polaris-immutables", configuration =
"processor"))
+ runtimeOnly(project(":polaris-persistence-nosql-metastore"))
+ runtimeOnly(project(":polaris-persistence-nosql-cdi-quarkus"))
+ runtimeOnly(project(":polaris-persistence-nosql-cdi-quarkus-distcache"))
+ runtimeOnly(project(":polaris-persistence-nosql-maintenance-impl"))
+ runtimeOnly(project(":polaris-persistence-nosql-metastore-maintenance"))
Review Comment:
Since we already did this for JDBC, adding these makes sense.
That said, looking at the `build.gradle.kts`, we now have test dependencies
for multiple persistence implementations in the service module. The main
implementation already separates persistence backends from runtime/service,
reflecting that the service layer logic is designed to be abstract and agnostic
to specific persistence implementations. In the long term, it might be worth
migrating the persistence-backend integration tests (both JDBC and NoSQL) to
separate test modules to stay consistent with this separation.
Not a blocker
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
