dimas-b commented on code in PR #3468:
URL: https://github.com/apache/polaris/pull/3468#discussion_r2706354295
##########
runtime/service/src/main/java/org/apache/polaris/service/reporting/PolarisMetricsReporter.java:
##########
@@ -22,5 +22,6 @@
import org.apache.iceberg.metrics.MetricsReport;
public interface PolarisMetricsReporter {
- public void reportMetric(String catalogName, TableIdentifier table,
MetricsReport metricsReport);
+ void reportMetric(
+ String catalogName, TableIdentifier table, MetricsReport metricsReport,
long timestampMs);
Review Comment:
That makes sense, however, different Polaris nodes may have different
clocks. Nothing guarantees that those clocks are in sync... I'm not sure using
a timestamp that is strict only inside one node helps that much... but maybe
I'm missing something :thinking:
I'm not against this change, just wondering if it is actually a benefit as
opposed to false hope :thinking: WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
