adutra commented on code in PR #3468: URL: https://github.com/apache/polaris/pull/3468#discussion_r2708001204
########## runtime/service/src/main/java/org/apache/polaris/service/reporting/MetricsProcessingContext.java: ########## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.service.reporting; + +import java.util.Optional; +import org.apache.iceberg.catalog.TableIdentifier; +import org.apache.iceberg.metrics.MetricsReport; +import org.immutables.value.Value; + +/** + * Context information for metrics processing, providing access to request metadata, security + * context, and tracing information. + * + * <p>This immutable context object contains all the information needed to process and persist + * Iceberg metrics reports, including catalog and table identifiers, the metrics report itself, and + * associated metadata like principal name, request ID, and OpenTelemetry trace context. + */ [email protected] +public interface MetricsProcessingContext { + + /** The catalog name where the metrics originated */ + String catalogName(); + + /** The table identifier */ + TableIdentifier tableIdentifier(); + + /** The Iceberg metrics report (ScanReport or CommitReport) */ + MetricsReport metricsReport(); + + /** The realm ID */ + String realmId(); + + /** The catalog ID (internal entity ID) */ + Optional<Long> catalogId(); + + /** The principal name who submitted the metrics */ + Optional<String> principalName(); + + /** The request ID for correlation */ + Optional<String> requestId(); Review Comment: I'm seeing many areas of Polaris trying to access common information such as the request ID, the realm ID, the Polaris principal and the OTel context. First, the Events API introduced access to this data in `PolarisEventMetadataFactory` (you will notice that retrieving this info is less trivial than you'd think). Then, `PolarisPrincipalHolder` was introduced, duplicating the logic in `PolarisEventMetadataFactory.getUser()`. And now, it seems that the metrics reporting area will also make usage of that same info. That's fine for now if each part of Polaris does the job locally; but I think some cleanup after this PR would be welcome. We should find a way to expose this data to the rest of the application in a consistent, centralized manner. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
