yj-lee0503 commented on PR #3480: URL: https://github.com/apache/polaris/pull/3480#issuecomment-3774781344
👋 Hi @adutra, I appreciate your thoughtful review and suggestions. I made updates based on your feedback: - Removed the logger field from `ExternalCatalogFactory` and inlined logging in the default methods - Replaced the custom merge logic with `org.apache.iceberg.rest.RESTUtil.merge()` in the Iceberg REST, Hive, and Hadoop factories - Adjusted the tests to align with the `RESTUtil.merge()` behavior we rely on If you have a moment, I would really appreciate another look. If there is anything else you would prefer to see structured differently, I am happy to revise. Thanks again! 🙇♂️ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
