MonkeyCanCode commented on PR #3496: URL: https://github.com/apache/polaris/pull/3496#issuecomment-3780826853
> > our current code base will add wildcard KMS policy to it if the backend is "AWS" [...] > > Why not make this an explicit flag in storage config? The admin user will set it (or not) based on the specific deployment situation. Yes, was thinking about a new config as suggested by you and @evindj but was tried to minimize the new config flag. However, as what @snazy pointed out, localstack will be using non-AWS FQDN but it does supports all of the things we needed here which can be FP as well. In this case, a new config flag may be better than blindly check endpoint and AWS domain name (another edge case that I can think will be aws s3outposts but this may not be covered with current code as well). Let me revised this config flag. thanks for review and feedback @dimas-b @evindj @snazy -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
