dimas-b commented on code in PR #3456: URL: https://github.com/apache/polaris/pull/3456#discussion_r2714928443
########## runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergRestCatalogEventServiceDelegator.java: ########## Review Comment: `EventAttributeMap` is a proper CDI bean now. It should be ok to rely on CDI to create and pass around (inject) one instance of it per request. If we want to distinguish before/after data, we could do that by code / methods inside `EventAttributeMap`. As I commented in another thread, I see value in evolving this class to become a rich and typed container of event-related data for each request (more than a simple key-value map). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
