pingtimeout opened a new pull request, #3513: URL: https://github.com/apache/polaris/pull/3513
As part of #3256 , the following test libraries were added from the Nessie project: * `objet-storage-mock` - Allows for mocking the object storage layer and simulate any Iceberg table, including tables with extremely large number of files * `azurite-testcontainer` - Allows for simulating Azure Storage with testcontainers in Polaris codebase * `gcs-testcontainer` - Allows for simulating GCS with testcontainers in Polaris codebase There was an explicit request to pull the code into Polaris, instead of depending on that code as a library (https://github.com/apache/polaris/pull/3256#discussion_r2673402956, https://github.com/apache/polaris/pull/3256#pullrequestreview-3640674712). This is what this PR does. This PR introduces three test-only libraries in the `tools` directory so that they can be used by #3256. In case it can be useful, [here is a bash script](https://github.com/user-attachments/files/24819477/generate-nessie-diff-commands.sh) that generates `diff` commands for all files added in this PR against a Nessie folder. It can be used to verify that the code that comes from Nessie has not been modified, apart from package names, code-copied-to-polaris marker and other minor tweaks. I have also tested the current PR by integrating it with #3256 and verifying that all the tests from #3256 still pass. ## Checklist - [x] ๐ก๏ธ Don't disclose security issues! (contact [email protected]) - [x] ๐ Clearly explained why the changes are needed, or linked related issues: Fixes # - [ ] ๐งช Added/updated tests with good coverage, or manually tested (and explained how) - [x] ๐ก Added comments for complex logic - [ ] ๐งพ Updated `CHANGELOG.md` (if needed) - [ ] ๐ Updated documentation in `site/content/in-dev/unreleased` (if needed) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
