singhpk234 commented on PR #3513: URL: https://github.com/apache/polaris/pull/3513#issuecomment-3791814494
Thank you for sharing this @dimas-b ! I believe thats precisely i was looking to get answer for ! I wonder if can't we adjust the tests to work with s3mocks rather than writing whole req / responses even introducing things like [Owner](https://github.com/apache/iceberg/pull/1573/changes#diff-49a96e7eea8a94af862798a45174e6ac43eb4f8b4bd40759b5da63ba31ec3ef7R254). my understanding was that iceberg uses s3 mock [pointer](https://github.com/apache/iceberg/pull/1573/changes#diff-49a96e7eea8a94af862798a45174e6ac43eb4f8b4bd40759b5da63ba31ec3ef7R254), even trino uses s3 mock [Trino](https://github.com/trinodb/trino/pull/27257) so i was confused on what exactly are we testing thats not possible with s3mock as we see other projects which do similar stuff is capable of. I believe we just want to check it in and use it for tests (https://github.com/apache/polaris/pull/3256) without changing we have and think about it later ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
