adutra commented on code in PR #3507: URL: https://github.com/apache/polaris/pull/3507#discussion_r2726904488
########## CHANGELOG.md: ########## @@ -31,9 +31,12 @@ request adding CHANGELOG notes for breaking (!) changes and possibly other secti ### Upgrade notes +- The custom token-bucket based rate limiter has been replaced with Guava's rate limiter implementation. + ### Breaking changes - The (Before/After)CommitTableEvent has been removed. +- The configuration option `polaris.rate-limiter.token-bucket.window` is no longer supported and should be removed. Review Comment: I think I agree with @dimas-b, the `Deprecations` section seems like a better fit for this announcement. When the property is fully removed, then we would put a note under this section (since that would be a hard breaking change). I see that this is what we did, e.g. for the EclipseLink phase out. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
