MonkeyCanCode opened a new pull request, #3586: URL: https://github.com/apache/polaris/pull/3586
<!-- ๐ Describe what changes you're proposing, especially breaking or user-facing changes. ๐ See https://github.com/apache/polaris/blob/main/CONTRIBUTING.md for more. --> Per discussion in https://lists.apache.org/thread/8o31ly7cd8ov70opjbtg630qlhrfl5yh, we should separate getting started example and integration testings in the codebase (there are known issues we discovered as well as reported by community when using RustFS, however, these won't impact our getting start examples as they are not using testcontainers). With this change, we will be able to remove the disclaimer banner on the first couple pages users will be seeing (IMO, better UX and make users more confident about the project as we are not using vulnerability images). Two small NITs for this PR: 1. Change auth from minio specific to more generic ones 2. use dash instead of underscore for service name (be consistent with the other one...so changed from `setup_bucket` to `bucket-setup`) ## Checklist - [x] ๐ก๏ธ Don't disclose security issues! (contact [email protected]) - [x] ๐ Clearly explained why the changes are needed, or linked related issues: Fixes # - [x] ๐งช Added/updated tests with good coverage, or manually tested (and explained how) - [x] ๐ก Added comments for complex logic - [x] ๐งพ Updated `CHANGELOG.md` (if needed) - [x] ๐ Updated documentation in `site/content/in-dev/unreleased` (if needed) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
