MonkeyCanCode opened a new pull request, #3587:
URL: https://github.com/apache/polaris/pull/3587

   <!--
   ๐Ÿ“ Describe what changes you're proposing, especially breaking or user-facing 
changes. 
   ๐Ÿ“– See https://github.com/apache/polaris/blob/main/CONTRIBUTING.md for more.
   -->
   
   So currently users can just do `docker compose up -d` on ceph example due to 
the non-deterministic bucket creation service (as it is simply sleep for 5 
seconds without proper service check). Also, the current README.md is a bit 
length and ask users to run various command to start services in-order (which 
is a bit un-necessary as the right ordering are already been defined via 
`depends_on`.
   
   This PR simplify the doc a bit to allow user to run a single command to 
start the services. Also, a small nit fixing for using dash instead of 
underscore for service name (`setup_bucket` to `bucket-setup`). Beside this, I 
also added a gitignore to exclude files created by this docker compose.
   
   Here is error users can get if run `docker compose up -d` (which is failing 
silently):
   ```
   + echo '>>> Waiting for RGW to become ready...'
   + sleep 5
   >>> Waiting for RGW to become ready...
   + echo '>>> Create bucket if not exist...'
   + aws s3 mb s3://polaris-storage
   >>> Create bucket if not exist...
   make_bucket failed: s3://polaris-storage Could not connect to the endpoint 
URL: "http://rgw1:7480/polaris-storage";
   + true
   + tail -f /dev/null
   ```
   
   And here is the output with current PR (matching output layout to the other 
docker-compose files for this specific service and ensure service):
   ```
   Creating Ceph bucket...
   make_bucket: polaris-storage
   2026-01-28 01:50:49 polaris-storage
   Bucket setup complete.
   ```
   
   ## Checklist
   - [x] ๐Ÿ›ก๏ธ Don't disclose security issues! (contact [email protected])
   - [x] ๐Ÿ”— Clearly explained why the changes are needed, or linked related 
issues: Fixes #
   - [x] ๐Ÿงช Added/updated tests with good coverage, or manually tested (and 
explained how)
   - [x] ๐Ÿ’ก Added comments for complex logic
   - [x] ๐Ÿงพ Updated `CHANGELOG.md` (if needed)
   - [x] ๐Ÿ“š Updated documentation in `site/content/in-dev/unreleased` (if needed)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to