snazy commented on code in PR #3587:
URL: https://github.com/apache/polaris/pull/3587#discussion_r2736350584
##########
getting-started/ceph/README.md:
##########
@@ -47,56 +47,12 @@ Note: this example pulls the `apache/polaris:latest` image,
but assumes the imag
cp .env.example .env
```
-### 2. Start monitor and manager
+### 2. Start the docker compose group by running the following command:
```shell
-docker compose up -d mon1 mgr
+docker compose up -d
```
-### 3. Start OSD
-```shell
-docker compose up -d osd1
-```
-
-### 4. Start RGW
-```shell
-docker compose up -d rgw1
-```
-#### Check status
-```shell
-docker exec --interactive --tty ceph-mon1-1 ceph -s
Review Comment:
I think this should stay, but the options `--interactive --tty ` removed.
##########
getting-started/ceph/docker-compose.yml:
##########
@@ -126,11 +126,18 @@ services:
- ./ceph-conf:/etc/ceph
depends_on:
- osd1
+ healthcheck:
+ test: ["CMD", "curl", "-f", "http://localhost:7480";]
+ interval: 2s
+ timeout: 10s
+ retries: 10
+ start_period: 10s
- setup_bucket:
+ bucket-setup:
image: amazon/aws-cli:2.33.8
depends_on:
- - rgw1
+ rgw1:
+ condition: service_healthy
Review Comment:
That's a very good one!
##########
getting-started/ceph/docker-compose.yml:
##########
@@ -126,11 +126,18 @@ services:
- ./ceph-conf:/etc/ceph
depends_on:
- osd1
+ healthcheck:
+ test: ["CMD", "curl", "-f", "http://localhost:7480";]
+ interval: 2s
+ timeout: 10s
+ retries: 10
+ start_period: 10s
- setup_bucket:
+ bucket-setup:
Review Comment:
Not sure this rename is necessary. The other guides use the same name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
