MonkeyCanCode commented on code in PR #3612:
URL: https://github.com/apache/polaris/pull/3612#discussion_r2748020468
##########
getting-started/ceph/docker-compose.yml:
##########
@@ -148,10 +148,10 @@ services:
command:
- "-c"
- >-
- echo Creating Ceph bucket...;
- aws s3 mb s3://${S3_POLARIS_BUCKET};
- aws s3 ls;
- echo Bucket setup complete.;
+ echo Creating Ceph bucket... &&
+ aws s3 mb s3://${S3_POLARIS_BUCKET} &&
+ aws s3 ls &&
+ echo Bucket setup complete.
Review Comment:
So we have at most 2 setup services for these docker compose and you are
adding `sleep 120` to pass the CI based on docker-compose (as exit of status
code of zero will be treat as failed). Thus, this will also return status code
of zero.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
