snazy commented on code in PR #3612:
URL: https://github.com/apache/polaris/pull/3612#discussion_r2749270997
##########
getting-started/ceph/docker-compose.yml:
##########
@@ -148,10 +148,10 @@ services:
command:
- "-c"
- >-
- echo Creating Ceph bucket...;
- aws s3 mb s3://${S3_POLARIS_BUCKET};
- aws s3 ls;
- echo Bucket setup complete.;
+ echo Creating Ceph bucket... &&
+ aws s3 mb s3://${S3_POLARIS_BUCKET} &&
+ aws s3 ls &&
+ echo Bucket setup complete.
Review Comment:
Ah, I think I know what you're referring to.
Those setup-bucket services behave in an "interesting" way, which is
different than how the "final" polaris-setup services behave (in terms of exit
behavior).
An "intermediate" setup-service like `setup-bucket`, on which for example
`polaris` depends using the `service_completed_successfully` condition, is fine
to exit and does not "break" a `docker compose up --detach --wait`.
A "final" setup-service like some `polaris-setup`, a service that no other
service depends on, lets `docker compose up --detach --wait` fail when it exits.
The "crux" with those "final" setup-services is that the behavior isn't
immediately obvious and depends on the timing of the relevant services and when
exactly `docker compose up --detach --wait` "thinks" the whole compose thing is
ready.
But this ^^ is all from experiments. It's tricky to find good documentation
on this behavior. However, the behavior of `depends_on` (... a setup service)
with `service_completed_successfully` condition makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
