dimas-b commented on code in PR #3649: URL: https://github.com/apache/polaris/pull/3649#discussion_r2789892921
########## helm/polaris/Chart.yaml: ########## @@ -37,3 +37,15 @@ maintainers: # Maintainers section is kept only to satisfy the Helm Chart Spec - name: gerrit-k - name: snazy - name: flyrain +annotations: + artifacthub.io/links: | + - name: Homepage + url: https://polaris.apache.org/ + - name: Source Code + url: https://github.com/apache/polaris + - name: Documentation + url: https://polaris.apache.org/releases/1.3.0/ Review Comment: Do we have to reference a specific version here? Note: it's not aligned with `appVersion` above 🤔 Why not just `https://polaris.apache.org`? ########## helm/polaris/artifacthub-repo.yml: ########## @@ -17,5 +17,8 @@ # under the License. # -# See https://bugs.openjdk.org/browse/JDK-8349545 -org.jboss.weld.bootstrap.concurrentDeployment=false +# Artifact Hub repository metadata file +repositoryID: apache-polaris +owners: + - name: Apache Polaris PMC Review Comment: Technically, it's PPMC (still incubating) ########## helm/polaris/artifacthub-repo.yml: ########## @@ -17,5 +17,8 @@ # under the License. # -# See https://bugs.openjdk.org/browse/JDK-8349545 -org.jboss.weld.bootstrap.concurrentDeployment=false +# Artifact Hub repository metadata file +repositoryID: apache-polaris Review Comment: We have `https://artifacthub.io/packages/helm/apache-polaris/polaris` in Artifact Hub UI... TBH, I do not really know how it should align with the repository ID, but it looks a bit awkward ATM 🤔 ... WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
