sririshindra commented on PR #3719: URL: https://github.com/apache/polaris/pull/3719#issuecomment-3893840457
Thanks for the feedback @snazy and @flyrain. I understand the concern about safety. 1. On Auth: - I agree TABLE_WRITE_PROPERTIES might be too loose. Would you prefer I restrict this to CATALOG_MANAGE_CONTENT (catalog admins), or should we introduce a specific TABLE_REGISTER_OVERWRITE privilege? 2. On Behavior: - Currently, this simply performs a pointer swap. Old metadata/data files are left untouched (not deleted) to prevent accidental data loss. Since the old metadata location is not actually deleted, users can always use that to restore back to the previous state in critical cases. We can log the previous metadata location if necessary for data recovery purposes. - Regarding base-location: My current implementation leaves the base-location unchanged (pointing to the original table path). However, if the new metadata file lives in a different location (e.g. during a restore from a backup path), should I update the entity's base-location to match the new metadata's parent directory? As a next step, would you prefer I update the PR to throw an error when overwrite=true (disabling it for now) so we can merge the API changes first, or should I implement the stricter auth checks in this PR? My preference would be implement the auth checks in this PR itself, but I am open to suggestions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
