PhillHenry commented on code in PR #3729:
URL: https://github.com/apache/polaris/pull/3729#discussion_r2846043929
##########
spec/polaris-management-service.yml:
##########
@@ -987,6 +988,20 @@ components:
BEARER: "#/components/schemas/BearerAuthenticationParameters"
SIGV4: "#/components/schemas/SigV4AuthenticationParameters"
IMPLICIT: "#/components/schemas/ImplicitAuthenticationParameters"
+ GCP: "#/components/schemas/GcpAuthenticationParameters"
+
+ GcpAuthenticationParameters:
+ type: object
+ description: Leads to GoogleAuthManager being used.
+ allOf:
+ - $ref: '#/components/schemas/AuthenticationParameters'
+ properties:
+ quotaProject:
+ type: string
+ description: The project to which this call is billed. Avoids "The
biglake.googleapis.com API requires a quota project, which is not set by
default." error
Review Comment:
It appears not to be optional ("[even for free public
access](https://opensource.googleblog.com/2026/01/explore-public-datasets-with-apache-iceberg-and-biglake.html)")
therefore I have made them `required`.
##########
spec/polaris-management-service.yml:
##########
@@ -987,6 +988,20 @@ components:
BEARER: "#/components/schemas/BearerAuthenticationParameters"
SIGV4: "#/components/schemas/SigV4AuthenticationParameters"
IMPLICIT: "#/components/schemas/ImplicitAuthenticationParameters"
+ GCP: "#/components/schemas/GcpAuthenticationParameters"
+
+ GcpAuthenticationParameters:
+ type: object
+ description: Leads to GoogleAuthManager being used.
+ allOf:
+ - $ref: '#/components/schemas/AuthenticationParameters'
+ properties:
+ quotaProject:
+ type: string
+ description: The project to which this call is billed. Avoids "The
biglake.googleapis.com API requires a quota project, which is not set by
default." error
Review Comment:
It appears not to be optional ("[even for free public
access](https://opensource.googleblog.com/2026/01/explore-public-datasets-with-apache-iceberg-and-biglake.html)")
therefore I have made it `required`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
