PhillHenry commented on code in PR #3729:
URL: https://github.com/apache/polaris/pull/3729#discussion_r2854184333
##########
polaris-core/src/main/java/org/apache/polaris/core/connection/ConnectionConfigInfoDpo.java:
##########
@@ -117,7 +122,7 @@ public AuthenticationParametersDpo
getAuthenticationParameters() {
return serviceIdentity;
}
- private static final ObjectMapper DEFAULT_MAPPER;
+ @VisibleForTesting static final ObjectMapper DEFAULT_MAPPER;
Review Comment:
I really wanted to use the real mapper as if somebody changes one but not
the other, the test could give a false positive. Would it please be OK to keep
it package protected?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
