sungwy commented on code in PR #3916:
URL: https://github.com/apache/polaris/pull/3916#discussion_r2869657716
##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/resolver/Resolvable.java:
##########
@@ -39,6 +39,11 @@ public enum Resolvable {
* Resolve any additional top-level entities explicitly registered via
addTopLevelName, such as
* catalog/principal/principal-role names used for authorization beyond the
caller and reference
* catalog.
+ *
+ * <p>Note: this currently also covers requested {@code CATALOG_ROLE} names
because they share the
+ * same {@link PolarisResolutionManifest} registration surface ({@code
addTopLevelName}). Although
Review Comment:
An alternative is to introduce a larger scope change to add
`REQUESTED_CATALOG_ROLES` as a separate enum, and also to add a different
registration surface to the `PolarisResolutionManifest` for requested catalog
roles
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
