dimas-b commented on code in PR #3916:
URL: https://github.com/apache/polaris/pull/3916#discussion_r2873594192
##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/resolver/Resolvable.java:
##########
@@ -29,16 +29,19 @@ public enum Resolvable {
CALLER_PRINCIPAL,
/** Resolve the caller's activated principal-role entities. */
CALLER_PRINCIPAL_ROLES,
- /** Resolve catalog-role entities (e.g., roles attached in the reference
catalog). */
- CATALOG_ROLES,
+ /** Resolve caller-activated catalog-role entities in the reference catalog.
*/
Review Comment:
nit "caller-activated" is understandable, but still a bit cryptic IMHO 😅 How
about "Catalog Role entities referenced by the active PolarisPrincipal"?
The "activated" part is generally handled during request authentication, so
by the time the request reaches AuthZ, the Principal already has a fixed set of
role names in it, IIRC. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
