adutra commented on code in PR #3931:
URL: https://github.com/apache/polaris/pull/3931#discussion_r2883328947
##########
helm/polaris/templates/configmap.yaml:
##########
@@ -114,6 +114,9 @@ data:
{{- $_ = set $map "quarkus.management.port" (get (first
.Values.managementService.ports) "port") -}}
{{- /* CORS */ -}}
+ {{- if or .Values.cors.allowedOrigins .Values.cors.allowedMethods
.Values.cors.allowedHeaders .Values.cors.exposedHeaders
.Values.cors.accessControlMaxAge (ne .Values.cors.accessControlAllowCredentials
nil) -}}
Review Comment:
I wonder if we shouldn't simply introduce a `cors.enabled` property in the
Helm chart, wdyt?
##########
site/content/in-dev/unreleased/helm-chart/reference.md:
##########
@@ -317,6 +317,8 @@ weight: 900
### CORS
+When any `cors.*` value is set, `quarkus.http.cors.enabled=true` is
automatically added to the generated `application.properties`.
Review Comment:
I'm afraid this page is generated, you cannot add this paragraph here. You
can generate it with `make helm`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
