adutra commented on code in PR #3931:
URL: https://github.com/apache/polaris/pull/3931#discussion_r2883880186
##########
helm/polaris/templates/configmap.yaml:
##########
@@ -114,6 +114,9 @@ data:
{{- $_ = set $map "quarkus.management.port" (get (first
.Values.managementService.ports) "port") -}}
{{- /* CORS */ -}}
+ {{- if .Values.cors.enabled -}}
+ {{- $_ = set $map "quarkus.http.cors.enabled" "true" -}}
+ {{- end -}}
Review Comment:
I would actually move the end of this if block to line 138; IOW, if this
value is false, no CORS-related properties should be included.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
